[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#21804: 25.0.50; file-notify-tests failure on Cygwin
From: |
Michael Albinus |
Subject: |
bug#21804: 25.0.50; file-notify-tests failure on Cygwin |
Date: |
Fri, 30 Dec 2016 20:16:17 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) |
Ken Brown <kbrown@cornell.edu> writes:
> Hi Michael,
Hi Ken,
>> Ken Brown <kbrown@cornell.edu> writes:
>> I've added the new function Fgfile_monitor_name to gfilenotify.c. It
>> tells us the name of the used monitor. In my case (GNU/Linux), it is
>> GInotifyFileMonitor. In your case it is GPollFileMonitor.
>
> Actually it turns out to be GFamFileMonitor on my system, presumably
> because I have the gamin package installed. I'm going to see if I can
> figure out how GFamFileMonitor works.
Next time I have access to a cygwin machine I'll check. However, I
wonder whether we need to respect the polling period then. According to
<http://oss.sgi.com/projects/fam/faq.html#what_is_fam>, FAM does not poll.
> As a quick check, however, I applied the following patch...
>
> --- a/test/lisp/filenotify-tests.el
> +++ b/test/lisp/filenotify-tests.el
> @@ -73,7 +73,8 @@ file-notify--test-read-event
> ;; gio/gpollfilemonitor.c declares POLL_TIME_SECS 5. So we must
> ;; wait at least this time.
> ((and (string-equal (file-notify--test-library) "gfilenotify")
> - (string-equal (file-notify--test-monitor) "GPollFileMonitor"))
> + (or (string-equal (file-notify--test-monitor) "GPollFileMonitor")
> + (string-equal (file-notify--test-monitor) "GFamFileMonitor")))
> 7)
> ((file-remote-p temporary-file-directory) 0.1)
> (t 0.01))))
>
> ...and all the inexpensive tests passed. I'll keep playing with this.
It's OK for me if you commit this patch. You know cygwin behaviour much
better then I do.
> Best regards,
>
> Ken
Best regards, Michael.
- bug#21804: 25.0.50; file-notify-tests failure on Cygwin, (continued)
- bug#21804: 25.0.50; file-notify-tests failure on Cygwin, Michael Albinus, 2016/12/27
- bug#21804: 25.0.50; file-notify-tests failure on Cygwin, Ken Brown, 2016/12/27
- bug#21804: 25.0.50; file-notify-tests failure on Cygwin, Ken Brown, 2016/12/28
- bug#21804: 25.0.50; file-notify-tests failure on Cygwin, Michael Albinus, 2016/12/29
- bug#21804: 25.0.50; file-notify-tests failure on Cygwin, Ken Brown, 2016/12/29
- bug#21804: 25.0.50; file-notify-tests failure on Cygwin, Eli Zaretskii, 2016/12/30
- bug#21804: 25.0.50; file-notify-tests failure on Cygwin, Michael Albinus, 2016/12/30
- bug#21804: 25.0.50; file-notify-tests failure on Cygwin, Ken Brown, 2016/12/30
- bug#21804: 25.0.50; file-notify-tests failure on Cygwin, Eli Zaretskii, 2016/12/31
- bug#21804: 25.0.50; file-notify-tests failure on Cygwin, Michael Albinus, 2016/12/31
- bug#21804: 25.0.50; file-notify-tests failure on Cygwin,
Michael Albinus <=
- bug#21804: 25.0.50; file-notify-tests failure on Cygwin, Ken Brown, 2016/12/30