bug#25382: 25.1.91; easy-menu-add empty

[npostavs]

found 25382 23.2
tags 25382 notabug
quit

Andreas Röhler <andreas.roehler@easy-emacs.de> writes:

> GNU Emacs 25.1.91.1 (i686-pc-linux-gnu, GTK+ Version 3.14.5) of 2017-01-02
>
> At python-mode.el `easy-menu-add' is used, which stopped
> working. Having a look at the source, looks like an empty body is
> provided.

`easy-menu-add's body has been empty since at least 23.2, it was made
empty by [1: 59c7bf4].  As far as I can tell, it only exists to be more
compatible with XEmacs, so this is not a bug.

1: 2008-08-14 17:42:21 +0000 59c7bf4d7bf927e65c6cd40cf36e2e6bcbabfa78
  (easy-menu-add): Don't precompute keybindings since those precomputed values 
aren't used any more.

I propose the following patch for emacs-25 to clarify that:

>From 1a8caf7ad763aa03f279ec54ceec4ff9cc1d7237 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Sat, 7 Jan 2017 09:26:08 -0500
Subject: [PATCH v1] Clarify that easy-menu-add is a nop (Bug#25382)

* lisp/emacs-lisp/easymenu.el (easy-menu-add): Make it into an alias of
`ignore', like `easy-menu-remove'.
---
 lisp/emacs-lisp/easymenu.el | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/lisp/emacs-lisp/easymenu.el b/lisp/emacs-lisp/easymenu.el
index 603bbcd..4fc9a78 100644
--- a/lisp/emacs-lisp/easymenu.el
+++ b/lisp/emacs-lisp/easymenu.el
@@ -489,7 +489,7 @@ easy-menu-change
 
 ;; XEmacs needs the following two functions to add and remove menus.
 ;; In Emacs this is done automatically when switching keymaps, so
-;; here easy-menu-remove is a noop.
+;; here easy-menu-remove and easy-menu-add are a noops.
 (defalias 'easy-menu-remove 'ignore
   "Remove MENU from the current menu bar.
 Contrary to XEmacs, this is a nop on Emacs since menus are automatically
@@ -497,15 +497,16 @@ 'easy-menu-remove
 
 \(fn MENU)")
 
-(defun easy-menu-add (_menu &optional _map)
+(defalias 'easy-menu-add #'ignore
   "Add the menu to the menubar.
-On Emacs, menus are already automatically activated when the
-corresponding keymap is activated.  On XEmacs this is needed to
-actually add the menu to the current menubar.
+On Emacs this is a nop, because menus are already automatically
+activated when the corresponding keymap is activated.  On XEmacs
+this is needed to actually add the menu to the current menubar.
 
 You should call this once the menu and keybindings are set up
-completely and menu filter functions can be expected to work."
-  )
+completely and menu filter functions can be expected to work.
+
+\(fn MENU &optional MAP)")
 
 (defun add-submenu (menu-path submenu &optional before in-menu)
   "Add submenu SUBMENU in the menu at MENU-PATH.
-- 
2.9.3