[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#25505: 24.5; doc of `define-minor-mode': incorrect for :keymap
From: |
Michael Heerdegen |
Subject: |
bug#25505: 24.5; doc of `define-minor-mode': incorrect for :keymap |
Date: |
Wed, 15 Feb 2017 15:49:14 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) |
npostavs@users.sourceforge.net writes:
> The doc says "variable name" as opposed to "expression", I think it's
> clear that expression will be evaluated, and something which is not an
> expression will not be evaluated. I guess we could add "it should be
> an unquoted variable name..."
I agree with Drew that the paragraph about the KEYMAP arg could be
improved. Currently we have
| Optional KEYMAP is the default keymap bound to the mode keymap. If
| non-nil, it should be a variable name (whose value is a keymap), or
| ...
It's not clear that this is about specifying the _name_ of a keymap (a
symbol), in contrast to specifying a keymap (value).
I also agree that the doc could make clearer if and when the arguments
are evaluated.
Michael.