[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#354: "Added (how many lines, bytes?!) to file.txt"
From: |
npostavs |
Subject: |
bug#354: "Added (how many lines, bytes?!) to file.txt" |
Date: |
Sun, 02 Apr 2017 14:40:06 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Paul Eggert <eggert@cs.ucla.edu> writes:
> On 04/01/2017 08:55 PM, npostavs@users.sourceforge.net wrote:
>> + (build_string ("%s %d characters of `%s'"),
>> + build_string (NUMBERP (append) ? "Updated"
>> + : ! NILP (append) ? "Added"
>> + : "Wrote"),
>
> This should use AUTO_STRING instead of build_string.
Okay. (there seems to be a lot of different ways to create a lisp
string object)
> Also, follow the
> old code and use just one string (a format) instead of two, as it's
> more important to use idiomatic English than to save a few bytes in
> the Emacs executable.
I find the code more readable when there is only one format string,
instead of a conditional choosing amongst three. I'm not sure what you
mean about "idiomatic English" as both versions produce the same text.
- bug#354: "Added (how many lines, bytes?!) to file.txt", npostavs, 2017/04/01
- bug#354: "Added (how many lines, bytes?!) to file.txt", Eli Zaretskii, 2017/04/01
- bug#354: "Added (how many lines, bytes?!) to file.txt", npostavs, 2017/04/01
- bug#354: "Added (how many lines, bytes?!) to file.txt", Eli Zaretskii, 2017/04/02
- bug#354: "Added (how many lines, bytes?!) to file.txt", Paul Eggert, 2017/04/02
- bug#354: "Added (how many lines, bytes?!) to file.txt",
npostavs <=
- bug#354: "Added (how many lines, bytes?!) to file.txt", Paul Eggert, 2017/04/02
- bug#354: "Added (how many lines, bytes?!) to file.txt", npostavs, 2017/04/02
- bug#354: "Added (how many lines, bytes?!) to file.txt", npostavs, 2017/04/06