[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26378: 26.0.50; Hitting 'n' during ediff gives Error
From: |
npostavs |
Subject: |
bug#26378: 26.0.50; Hitting 'n' during ediff gives Error |
Date: |
Thu, 06 Apr 2017 19:38:26 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Kaushal Modi <kaushal.modi@gmail.com> writes:
>> > +The PROGRAM is executed asynchronously unless `system-type' is
>> > +`windows-nt' or `ms-dos', or unless SYNCH is non-nil.
>>
>> I think the second "unless" is redundant.
>>
>
> I prefer repeating 'unless' in this case where the subject is changing from
> system-type to SYNCH. It just adds clarity. Though, grammatically what you
> suggested is also correct. So for reducing redundancy, I'll go with your
> suggestion.
Yeah, I guess it could go either way.
>
>> > I have tweaked this part slightly (see patch in this email). Based on the
>> > code, nil and "" elements will be removed from a concatenated list of
>> > OPTIONS and FILES; not just FILES.
>>
>> But OPTIONS can't have nil or "" in it (or any "elements", really), so I
>> don't think there is any need to talk about that in the docstring.
>>
>
> That's correct. I've updated the patch with what you suggested earlier.
Thanks, I think this is ready to go in. Could you resend as an
attachment? It doesn't seem to apply, possibly because of line wrapping
and/or whitespace corruption.
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, Kaushal Modi, 2017/04/05
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, Kaushal Modi, 2017/04/05
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, Kaushal Modi, 2017/04/05
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, Noam Postavsky, 2017/04/05
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, Kaushal Modi, 2017/04/05
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, npostavs, 2017/04/05
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, Kaushal Modi, 2017/04/06
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, npostavs, 2017/04/06
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, Kaushal Modi, 2017/04/06
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error,
npostavs <=
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, Kaushal Modi, 2017/04/07
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, npostavs, 2017/04/07
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, Philipp Stephani, 2017/04/08
- bug#26378: 26.0.50; Hitting 'n' during ediff gives Error, Kaushal Modi, 2017/04/10