bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#20852: [PATCH] Warn about missing backslashes during load


From: Stefan Monnier
Subject: bug#20852: [PATCH] Warn about missing backslashes during load
Date: Mon, 01 May 2017 13:59:33 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

Looks great, thank you very much.  See comments below.

> +     if (c == '(' || c == ')' || c == '[' || c == ']'
> +            || c == '"' || c == ';')

These are indeed the most important ones w.r.t elisp-mode's
syntax-table, but I think we should put #, ?, and ' in there as well.
This said, maybe we should add chars in there "little by little" to try
and not overwhelm people with warnings.
So the above set might actually be a good set with which to start.

> +               doc: /* List of deprecated unescaped character literals 
> encountered by `read'.  For internal use only.  */);

Please keep the first line of docstrings with 80 columns.  I.e. move the
"For internal use only." to a second line.


        Stefan





reply via email to

[Prev in Thread] Current Thread [Next in Thread]