bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#26816: mouse movement support for OS X


From: Charles A. Roelli
Subject: bug#26816: mouse movement support for OS X
Date: Mon, 15 May 2017 20:23:27 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

I've added a `skip-unless' form to the beginning of the test:


(skip-unless (display-graphic-p))


Seems to take care of the issue.  Patch is attached, with a commit message.


On 14/05/2017 16:37, Eli Zaretskii wrote:
Date: Sun, 14 May 2017 14:59:10 +0100
From: Alan Third <alan@idiocy.org>
Cc: 26816@debbugs.gnu.org, martin rudalics <rudalics@gmx.at>,
        Eli Zaretskii <eliz@gnu.org>

On Sun, May 14, 2017 at 03:29:57PM +0200, Charles A. Roelli wrote:
Attached is a patch now working with multiple monitors.  I also added
`ns-set-mouse-absolute-pixel-position', a test and a NEWS entry.  The test
works interactively, but it requires a frame to run and I'm not sure whether
tests run with them by default.
Usually you run tests with ’make check’, and there’s no frame
available.
There's always a frame, even in batch sessions.  Observe:

   emacs -batch --eval "(message \"%s\" (selected-frame))"
     => #<frame F1 017b9d08>

It's just that it's not a frame which this feature could use.

I’ve just checked and it does throw up an error for that
test. I’m not sure how that should be handled.
You could explicitly test for non-interactive sessions, and skip the
test, or display a message that this test can only be run
interactively.  Would that be good enough?

Attachment: 0001-Fix-macOS-mouse-movement.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]