bug#27047: 26.0.50; Scroll bar menu UI glitches [patch]

[Stephen Berman]

The Options->Show/Hide->Scroll-bar menu functions correctly -- when you
press any of the five radio buttons, the result is what it should be --
but the UI is broken.  With -Q the vertical scroll bar is on the right,
there is no horizontal scroll bar and the menu shows the radio button
"None-horizontal" [sic] pressed.  If you press any of the other buttons
in that menu, the scroll bars change accordingly, but the menu continues
to show the same "None-horizontal" button pressed.  The attached patch
fixes this UI glitch.  In addition, I find the current scroll bar menu
somewhat incoherent and the patch offers an improvement (IMO): the radio
buttons are confined to the vertical scroll bar, and the two buttons for
the horizontal scroll bar are replaced by a single check box toggle, and
a separator is added to visually emphasize that two UI components are
involved.

While I was looking at the Show/Hide menu, I noticed that the spelling
there is not consistent with the convention of the Emacs manual, which
uses "scroll bar", "tool bar" and "menu bar" without hyphenation.  So
the patch changes the spelling of these in the menu and tooltips too.

In GNU Emacs 26.0.50 (build 19, x86_64-pc-linux-gnu, GTK+ Version 3.22.8)
 of 2017-05-22 built on rosalinde
Repository revision: bc78276e81956b3caa8a5eb7ef26959fa4c84b7b
Windowing system distributor 'The X.Org Foundation', version 11.0.11901000


2017-05-23  Stephen Berman  <Stephen.Berman@gmx.net>

        Fix and improve UI of scroll bar menu

        In addition, since the Emacs manual writes "scroll bar", "tool
        bar" and "menu bar", use this convention in the Show/Hide menues
        and tooltips as well.

        * lisp/menu-bar.el (menu-bar-showhide-scroll-bar-menu): Make
        pressing a radio button in the menu actually show that it was
        pressed.  Replace the two radio buttons to turn the horizontal
        scroll bar on and off with a single check-box toggle and add a
        separator between this and the vertical scroll bar radio
        buttons.
        (menu-bar-showhide-tool-bar-menu):
        (menu-bar-showhide-menu):
        (menu-bar-mode): Use conventional spelling.

txt7IKEKZeOhN.txt
Description: Show/Hide menu patch