bug#27111: mode-line-position is faulty after b0b02ca7

[Alan Mackenzie]

Hello, Alex and Eli.

On Sun, May 28, 2017 at 17:59:05 +0300, Eli Zaretskii wrote:
> > From: Alex <agrambot@gmail.com>
> > Date: Sat, 27 May 2017 22:35:12 -0600
> > Cc: Alan Mackenzie <acm@muc.de>

> > Start from emacs -Q:

> > Hover over the 'All' in the mode-line. Emacs does not show the tooltip.

> > Click on the 'All' in the mode-line. Emacs does not show the menu.

> Not just "All" -- any location indication is no longer
> mouse-sensitive.

> Alan, could you please take a look?o

The problem was I had spuriously quoted elements inside a backquote
structure.  This should be fixed by the following patch.

Alex, just to emphasise, though it's probably not necessary to say,
you'll have to rebuild Emacs, properly to incorporate this patch, since
binding.elc is preloaded.  Please try out this patch and either confirm
to me it's fixed the bug, or tell me what's still wrong.  Thanks for
taking the trouble to report this bug, and thanks in advance for trying
out the patch.  :-)



diff --git a/lisp/bindings.el b/lisp/bindings.el
index 0b4c3bda80..07f3441efd 100644
--- a/lisp/bindings.el
+++ b/lisp/bindings.el
@@ -382,14 +382,15 @@ mode-line-percent-position
                  (6 "%q")))
   :version "26.1"
   :group 'mode-line)
+(put 'mode-line-percent-position 'risky-local-variable t)
 
 (defvar mode-line-position
   `((:propertize
      mode-line-percent-position
-     'local-map mode-line-column-line-number-mode-map
-     'mouse-face 'mode-line-highlight
+     local-map ,mode-line-column-line-number-mode-map
+     mouse-face mode-line-highlight
      ;; XXX needs better description
-     'help-echo "Size indication mode\n\
+     help-echo "Size indication mode\n\
 mouse-1: Display Line and Column Mode Menu")
     (size-indication-mode
      (8 ,(propertize


-- 
Alan Mackenzie (Nuremberg, Germany).