bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27272: 25.2; [patch] Fix positional args among keyword args in eldoc


From: Johan Bockgård
Subject: bug#27272: 25.2; [patch] Fix positional args among keyword args in eldoc.
Date: Sat, 10 Jun 2017 18:15:28 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:

> Fix eldoc with positional arg among keyword args.
>
> * lisp/progmodes/elisp-mode.el (elisp--highlight-function-argument):
> Switch to indexed arg searching when no keyword found behind arg.

This code is wrong both with and without your fix. All mandatory and
optional arguments should be used *before* keywords are matched.

Given this definition of `foo',

    (cl-defun foo (x &key a b c)
      (list x a b c))

`:b' in the following call specifies the positional argument `x', not
the keyword argument `b':

    (foo :b :a 1)  =>  (:b 1 nil nil)





reply via email to

[Prev in Thread] Current Thread [Next in Thread]