[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#27946: 26.0.50; Commit 1f9f514e7c2ba41b0954d0141f99652f6a53a107 brea
From: |
Tino Calancha |
Subject: |
bug#27946: 26.0.50; Commit 1f9f514e7c2ba41b0954d0141f99652f6a53a107 breaks the build on Ubuntu 14.04 |
Date: |
Sat, 05 Aug 2017 13:08:11 +0900 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) |
Philipp Stephani <p.stephani2@gmail.com> writes:
> It appears that commit 1f9f514e7c2ba41b0954d0141f99652f6a53a107 breaks
> the build on Ubuntu 14.04:
>
> sysdep.c: In function ‘renameat_noreplace’:
> sysdep.c:2695:58: error: ‘RENAME_NOREPLACE’ undeclared (first use in this
> function)
> return syscall (SYS_renameat2, srcfd, src, dstfd, dst, RENAME_NOREPLACE);
>
> Probably the #ifdef there should also include RENAME_NOREPLACE.
I confirm i can build in Ubuntu-14.04 with this patch:
diff --git a/src/sysdep.c b/src/sysdep.c
index 22446b25d1..9eb733221e 100644
--- a/src/sysdep.c
+++ b/src/sysdep.c
@@ -2691,7 +2691,7 @@ set_file_times (int fd, const char *filename,
int
renameat_noreplace (int srcfd, char const *src, int dstfd, char const *dst)
{
-#ifdef SYS_renameat2
+#if defined SYS_renameat2 && defined RENAME_NOREPLACE
return syscall (SYS_renameat2, srcfd, src, dstfd, dst, RENAME_NOREPLACE);
#else
errno = ENOSYS;