bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27952: 26.0.50; Combine archive-int-to-mode and tar-grind-file-mode


From: Tino Calancha
Subject: bug#27952: 26.0.50; Combine archive-int-to-mode and tar-grind-file-mode
Date: Wed, 16 Aug 2017 22:10:17 +0900 (JST)
User-agent: Alpine 2.20 (DEB 67 2015-01-07)



On Wed, 16 Aug 2017, Andreas Schwab wrote:

On Aug 16 2017, Tino Calancha <tino.calancha@gmail.com> wrote:

+Note: This is not the inverse of `file-modes-symbolic-to-number';
+The reason is that this function might return an string containing 'S'
+or 'T' i.e., not valid characters for `file-modes-symbolic-to-number'.
+For example, (file-modes-symbolic-to-number \"o=t\") returns 512;
+and (file-modes-number-to-symbolic 512 t) returns \"o=T\"."

Why would it use uppercase T in the detailed case?  Uppercase is only
needed when it would overlay the 'x' position in the non-detailed case.
Not special reason i think.  To keep more similar with
the case when DETAILED is nil.
 (file-modes-number-to-symbolic 512)
=> "---------T"

At the end of the function that is changed into
"o=T"
with:

(funcall replace-fn
   (replace-regexp-in-string
      "-" "" ...

I liked like this when i wrote the patch.  We could changed it in
case is confusing.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]