bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#28080: 25.2; `outline-invisible-p' should be specific to `invisible'


From: npostavs
Subject: bug#28080: 25.2; `outline-invisible-p' should be specific to `invisible' property of `outline.el'
Date: Wed, 16 Aug 2017 19:34:04 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux)

forcemerge 24073 28080
quit

Drew Adams <drew.adams@oracle.com> writes:

> Here is a correct definition, AFAICT.  My own use of this indicates that
> it DTRT.  In particular, I believe that it handles all of the invisible
> text that Outline itself imposes, so that `outline.el' loses nothing by
> using it.
>
> (defun outline-invisible-p (&optional pos)
>   "Non-nil if the character after point is invisible for outline purposes."
>   (eq (get-char-property (or pos (point)) 'invisible) 'outline))

Yup, this is the definition in master.

> (It also should not be a `defsubst'.  1985 has come and gone.)

Except it is still a defsubst.  It is called within some loops, so
perhaps we should at least see some numbers before changing that?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]