[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#28227: 26.0.50; Tramp tests are slow
|
From: |
npostavs |
|
Subject: |
bug#28227: 26.0.50; Tramp tests are slow |
|
Date: |
Wed, 30 Aug 2017 22:26:33 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) |
Gemini Lasswell <gazally@runbox.com> writes:
> +(defmacro tramp-lookup-syntax (alist)
> + "Look up a syntax string in ALIST according to `tramp-compat-tramp-syntax.'
> +Raise an error if `tramp-syntax' is invalid."
> + `(let ((result (cdr (assq (tramp-compat-tramp-syntax) ,alist))))
> + (or result
> + (error "Wrong `tramp-syntax' %s" tramp-syntax))))
Was there a reason to defmacro instead of defun here? If it's
performance, perhaps defsubst could work instead?
(also, the let-binding seems redundant)