[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-render
From: |
Lars Ingebrigtsen |
Subject: |
bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions |
Date: |
Thu, 05 Oct 2017 22:10:52 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Vasilij Schneidermann <v.schneidermann@gmail.com> writes:
> How deeply nested does typical HTML get anyways?
Very.
> I recall an exemplary comment from an article on browser rendering
> that pointed out that they bail out on degenerate cases, so perhaps
> it's better to add that to shr rather than hoping you never hit the
> stack limit by following a conservative coding style.
shr does check and bail. Search for max-specpdl-size in shr.el.
> What I'd additionally do is adding a comment explaining why there's
> two very similar snippets of code doing the same thing, otherwise the
> next person proposing a patch will change only one of them and be left
> head-scratching why it doesn't quite work.
Sure; please submit a patch to do so.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions, Eli Zaretskii, 2017/10/05
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions, Lars Ingebrigtsen, 2017/10/05
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions, Eli Zaretskii, 2017/10/05
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions, Lars Ingebrigtsen, 2017/10/05
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions, Eli Zaretskii, 2017/10/05
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions, Lars Ingebrigtsen, 2017/10/05
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions, Eli Zaretskii, 2017/10/05
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions, Lars Ingebrigtsen, 2017/10/05
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions, Vasilij Schneidermann, 2017/10/05
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions,
Lars Ingebrigtsen <=
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions, Eli Zaretskii, 2017/10/06