bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-sele


From: Tino Calancha
Subject: bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection
Date: Fri, 13 Oct 2017 10:54:41 +0900 (JST)
User-agent: Alpine 2.20 (DEB 67 2015-01-07)



On Thu, 12 Oct 2017, Noam Postavsky wrote:

I think I would rather put it with the next condition:

--- i/lisp/simple.el
+++ w/lisp/simple.el
@@ -5336,7 +5336,9 @@ deactivate-mark
            ;; deactivation should not clobber it (Bug#11772).
            ((and (/= (region-beginning) (region-end))
                  (or (gui-backend-selection-owner-p 'PRIMARY)
-                     (null (gui-backend-selection-exists-p 'PRIMARY))))
+                      (null (gui-backend-selection-exists-p 'PRIMARY)))
+                  ;; `winner-undo' shouldn't update the selection (Bug#28631).
+                  (not (eq this-command 'winner-undo)))
             (gui-set-selection 'PRIMARY
                                (funcall region-extract-function nil)))))
    (when mark-active (force-mode-line-update)) ;Refresh toolbar (bug#16382).

Either way, I think it's okay to push emacs-26, but wait a bit in case
someone else thinks otherwise.
OK.
Thank you very much.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]