bug#28685: 25.3; wrong handling ~/.cpp.el

[Eli Zaretskii]

> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Sat, 14 Oct 2017 01:38:47 -0400
> Cc: 28685@debbugs.gnu.org
> 
> Masatake YAMATO <yamato@redhat.com> writes:
> 
> > cpp.el tries to load ./.cpp.el even when it is not readable.  Though
> > it checks ~/.cpp.el can be readable, it still tries to load ./.cpp.el.
> 
> Thanks, the patch looks good.  But since this bug has apparently been
> present since the initial revision in 1994 and nobody ever noticed until
> now, I wonder if we should instead just remove the ~/.cpp.el feature
> altogether.

AFAIK, it's a standard feature of many packages (not only Emacs
packages) to try .FOO in the home directory if the one in the CWD is
not usable.  So I think we should fix this rather than remove the
feature.  (cpp.el is under-used in general, so it's small wonder no
one paid attention to this bug.)

Btw, I think we should use expand-file-name rather than concat, to
access ~/.cpp.el.

Thanks.