[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#28803: [PATCH] Fixed compiler warnings for advised functions.
From: |
Noam Postavsky |
Subject: |
bug#28803: [PATCH] Fixed compiler warnings for advised functions. |
Date: |
Sat, 14 Oct 2017 19:47:15 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) |
John Williams <jrw@pobox.com> writes:
> Oops. Is there anything that can be salvaged from my patch? Aside
> from fixing the bug, it also adds a unit test and refactors the logic
> for finding a function's argument list into a separate function
> that's not part of the help system.
We could add the test, it seems to be passing in emacs-26. Have you
assigned copyright to Emacs? (It's okay if you haven't, the patch is
small enough to go in regardless, we would just need to mark it.)
I don't think there's much need for moving the function argument
retrieval out of the help system.
(By the way, if you've spent some time looking at help-function-arglist,
perhaps you have some ideas about Bug#26270?
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26270)