|
From: | Paul Eggert |
Subject: | bug#28824: 26.0.90; display of pbm images broken? |
Date: | Mon, 16 Oct 2017 01:30:07 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
Eli Zaretskii wrote:
From: Andy Moreton <andrewjmoreton@gmail.com> Date: Sun, 15 Oct 2017 18:42:27 +0100 Eli can decide if reverting the previous "unsigned char" -> "char" changes is a better fix.Looks like going back to unsigned should be cleaner, but I'd like to hear what Paul thinks.
Andy's fixes look good to me. Going back to unsigned would result in several pointer casts that are more dangerous than converting to unsigned. They can be further improved by encapsulating this stuff into a function, and I installed the attached (the second one is Andy's other fix, which I installed in his name).
I looked for related bugs in image.c (i.e., caused by my earlier patch) and did not find any.
0001-Fix-regression-in-display-of-PPM-images.patch
Description: Text Data
0002-Don-t-reject-PBM-header-whitespace-unnecessarily.patch
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |