bug#27940: Recursively delete dir34? (yes, no, all, quit)

[Noam Postavsky]

Tino Calancha <tino.calancha@gmail.com> writes:

> Those tests implicitely assume you keep the
> 'dired-recursive-deletes' default, i.e. 'top; IMO it's not
> sorprising that they fail if you run them interactively
> with other 'dired-recursive-deletes' value.

It is failing for me when I run non-interactively:

    make -C test dired-tests

Does it not fail for you?

> We could explicitely set 'dired-recursive-deletes' 'top if you
> prefer that.

I tried also binding it during the test, but it still failed:

modified   test/lisp/dired-tests.el
@@ -364,7 +364,8 @@ dired-test-with-temp-dirs
   (declare (indent 1) (debug body))
   (let ((dir (make-symbol "dir"))
         (ignore-funcs (make-symbol "ignore-funcs")))
-    `(let* ((,dir (make-temp-file "bug27940" t))
+    `(let* ((dired-recursive-deletes 'top)
+            (,dir (make-temp-file "bug27940" t))
             (dired-deletion-confirmer (lambda (_) "yes")) ; Suppress prompts.
             (inhibit-message t)
             (default-directory ,dir))