bug#28872: 26.0.90; non-native-fullscreen does not play well with ns-transparent-titlebar on macOS

[Aaron Jensen]

On October 25, 2017 at 6:38:23 AM, Alan Third
(alan@idiocy.org(mailto:alan@idiocy.org)) wrote:

> On Fri, Oct 20, 2017 at 07:35:35AM -0400, Aaron Jensen wrote:
> > Oh, why is that? I believe that is the time that iTerm2 does not
> > create a new window. It sets borderless and resizes to full screen. If
> > that were done instead, would it help with the toolbar issue?
>
> Yeah, we could probably do it without creating a new NSWindow for
> macOS and I think it would be better behaved, but GNUstep doesn’t
> allow you to change the styleMask at all so it still needs to do the
> new NSWindow thing.
>
> In order to use lisp to do the fullscreen thing we’d need to keep
> track of various ‘windowed’ frame parameters, ie. undecorated, width,
> height, origin, maybe others. I assume it would be OK to stick them
> into the frame-parameters alist under a special key, so we know where
> they are when we want to switch back.

This seems reasonable to me. I wonder if it would fix the lag when
full-screening that’s there now. That’s always bugged me.

> Anyway, I’ve pushed a fix for this particular issue.

I can confirm that it fixes the issue for me.

> It does produce
> another odd bug, though:
>
> Set non‐native fullscreen, turn off the toolbar, switch to fullscreen
> then back to windowed, re‐enable the toolbar and watch a gap appear
> between the top of the Emacs window and the toolbar.
>
> It’s weird, but harder to cause than the current bad behaviour.

I can confirm this as well. It seems that going to fullscreen and then
back removes it after turning the toolbar back off. This won’t impact
me as I don’t use the toolbar at all, but I agree that this is a weird
bug.

One other thing I notice is that when reenabling the toolbar the
window gets taller in height, causing the bottom to slide off screen
if it is already full-height. This isn’t a big deal for me, and
probably has been that way for a while, but I imagine some would find
it annoying.

Aaron