[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#29334: 25.3; compiled commands don't respect special interactive exp
From: |
Noam Postavsky |
Subject: |
bug#29334: 25.3; compiled commands don't respect special interactive expressions |
Date: |
Fri, 24 Nov 2017 07:17:58 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>> To fix this, change `call-interactively' so that it checks compiled
>> functions for lexical-binding as well. Then the byte-compiler can
>> preserve the source of interactive forms regardless of the value of
>> lexical-binding.
>
> Thanks. If no objections are voiced to this approach, please push it
> to the master branch. I think this is too radical for the release
> branch.
Hah, okay, but that was the conservative approach! The radical one
would be resolving this FIXME:
static void
fix_command (Lisp_Object input, Lisp_Object values)
{
/* FIXME: Instead of this ugly hack, we should provide a way for an
interactive spec to return an expression/function that will re-build
the
args without user intervention. */
> P.S. Should this change be reflected in the ELisp manual somehow?
I don't see where.