bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#29081: 25.1; define-globalized-minor-mode does not respect :variable


From: Noam Postavsky
Subject: bug#29081: 25.1; define-globalized-minor-mode does not respect :variable of original mode
Date: Sat, 02 Dec 2017 14:04:26 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux)

tags 29081 + confirmed easy
quit

k@rdw.se (Chris Stj) writes:

> The problem lies in the "if ,mode" condition. This assumes the minor
> mode variable has the same name as the minor mode itself; which is
> clearly not true when something else is specified with the :variable
> keyword in the minor mode definition.

> I guess the best solution may be to allow users of
> define-globalized-minor-mode to specify the place in which the minor
> mode stores its state, since I can't find a good, generic way to extract
> this from the minor mode definition itself, after the fact.

Makes sense to me.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]