bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#29763: New Feature: Remove unneeded eval-expression in minibuffer-hi


From: Robert Weiner
Subject: bug#29763: New Feature: Remove unneeded eval-expression in minibuffer-history
Date: Fri, 22 Dec 2017 09:21:38 -0500

On Fri, Dec 22, 2017 at 7:58 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
On Dez 17 2017, Robert Weiner <rsw@gnu.org> wrote:

> + (defun minibuffer-history-edit-element (elt)
> +   "Automatically simplify ELT if possible, e.g. removing eval-_expression_."
> +   (or (and (consp elt) (eq (car elt) 'eval-_expression_)
> +        ;; Remove eval-_expression_ wrapper and leave just the _expression_.
> +        (cadadr elt))

That mishandles self-evaluating expressions, they are not wrapped with
quote.

​You are correct.  This version resolves that issue and changes
repeat-complex-command to use eval-_expression_ instead of
funcall-interactively to handle expressions rather than function
calls, including properly redoing:

   (quote emacs-version)

for example.

See attached.

Bob


Attachment: simple.el.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]