[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a sing
From: |
Marcin Borkowski |
Subject: |
bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren |
Date: |
Tue, 02 Jan 2018 09:55:47 +0100 |
User-agent: |
mu4e 0.9.19; emacs 27.0.50 |
On 2017-12-19, at 17:15, Eli Zaretskii <eliz@gnu.org> wrote:
>> So I did take a look. The mention in the manual is already there,
>> I forgot I did that back then.
>
> Right, sorry I missed that somehow.
No problem.
>> Where should I put the tests?
>> I expected something in e.g. test/lisp/textmodes/fill.el, but there's
>> nothing like that there.
>
> If the file doesn't exist, create it.
>
>> Also, should I test only my function, or filling with it, or both?
>
> I think filling with your function is the most important thing to
> test.
>
> Thanks.
So that's what I did (see commit 1ad94a126b on branch fix/bug-20871,
http://git.savannah.gnu.org/cgit/emacs.git/log/?h=fix/bug-20871). Is
that ok? I admit that these tests are rather simplistic, and I'm still
not sure about my commit message.
Best,
--
Marcin Borkowski
- bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren,
Marcin Borkowski <=
- bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren, Eli Zaretskii, 2018/01/13
- bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren, Marcin Borkowski, 2018/01/13
- bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren, Marcin Borkowski, 2018/01/15
- bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren, Marcin Borkowski, 2018/01/15
- bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren, Eli Zaretskii, 2018/01/15
- bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren, Marcin Borkowski, 2018/01/24
- bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren, Eli Zaretskii, 2018/01/24