Eli Zaretskii <
eliz@gnu.org> schrieb am Do., 18. Jan. 2018 um 15:05 Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Cc: Philipp Stephani <phst@google.com>
> Date: Wed, 17 Jan 2018 23:28:46 +0100
>
> * src/systhread.c (sys_thread_equal): New function.
> * src/emacs-module.c (in_current_thread): Use it.
I'd prefer that the only file that calls systhread.c functions is
thread.c; systhread.c is supposed to be low-level code concealed from
application levels. So this would call for another level of
indirection: add a new function to thread.c, and call that from
emacs-module.c.
Makes sense, I've moved in_current_thread to thread.c because it's unrelated to modules.
Otherwise, LGTM for master; thanks.
Can we push this to emacs-26? Right now emacs-26 can't even be compiled with --without-threads --with-modules (on some systems at least).