|
From: | Paul Eggert |
Subject: | bug#30176: readlinkat and _FORTIFY_SOURCE on Cygwin |
Date: | Fri, 19 Jan 2018 15:25:02 -0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/19/2018 12:46 PM, Ken Brown wrote:
I can think of three possibilities, but maybe there's something better: 1. Add "#define _FORTIFY_SOURCE 0' at the top of fileio.c (Cygwin only).2. Pretend like Cygwin doesn't have readlinkat. Then gnulib will create its own definition, which will be found by the linker in libegnu.a.3. Ask gnulib to come up with a fix.
(2) is presumably not good, since the substitute readlinkat will have to execute several system calls and this will be problematic.
(1) should work but kind of misses the point of fortification. I don't know what would be involved in (3). How about a better option, like this:4. Fix Cygwin readlinkat so that it can be used as a function pointer even when _FORTIFY_SOURCE is used.
Why not do what glibc does with readlinkat? It fortifies readlinkat, and doesn't run into this problem.
[Prev in Thread] | Current Thread | [Next in Thread] |