bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for


From: Philipp Stephani
Subject: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames
Date: Tue, 30 Jan 2018 19:22:34 +0000



Eli Zaretskii <eliz@gnu.org> schrieb am Di., 30. Jan. 2018 um 14:46 Uhr:
> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Sun, 28 Jan 2018 09:58:21 -0500
> Cc: 30243@debbugs.gnu.org, Philipp Stephani <p.stephani2@gmail.com>
>
> > The branch scratch/nonspecial-handlers is based on Emacs 26.0.91, do you
> > plan to merge it there?
>
> Yeah, I agree with Phillip that breaking "/:" files for the release
> would be quite a severe regression.
>
> > I feel a little bit uncomfortable with this, because my fix in
> > file-notify-add-watch didn't get heavy testing.
>
> However, if you think the file-notify fix might possibly affect other
> things, I think leaving that part out for 26.1 would be acceptable.
>
> Now that the code is ready, perhaps Eli has something to say on where it
> should go?

I think to make up my mind I'd need a few words about each part of the
changes (with the exception of the test suite changes): why is each of
them needed, and what does it do to fix which part of the original
problem.

I also wonder how come we've succeeded to break quoted file names so
fundamentally -- what change did that, and why did we make it on the
release branch?


If my git bisect is correct, it was commit a1bbc490155b61a634a6d0b165000ce35b93aa35 to fix Bug#29579. So by fixing one bug we introduced another one :(

reply via email to

[Prev in Thread] Current Thread [Next in Thread]