bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#30280: async-shell-command-display-buffer doesn't work anymore


From: Eli Zaretskii
Subject: bug#30280: async-shell-command-display-buffer doesn't work anymore
Date: Fri, 02 Feb 2018 12:42:14 +0200

> From: Juri Linkov <address@hidden>
> Cc: Eli Zaretskii <address@hidden>,  Reuben Thomas <address@hidden>,  
> <address@hidden>
> Date: Wed, 31 Jan 2018 23:44:43 +0200
> 
> > I attach a patch which addresses both bugs.  Its solution for (a) is to
> > make the advice disposable, i.e. it removes itself from the process
> > filter after it has fulfilled its purpose of displaying the output
> > buffer.  A syntactically simpler implementation of this could use a
> > plain boolean switch instead of removing the advice, but IMO the latter
> > is semantically more sound (and possibly more performant in subsequent
> > invocations of the process filter, though this should be irrelevant).
> >
> > WDYT?
> 
> Thanks, I confirm this is the right thing to do and your patch fixes
> the reported issue.

Then please push them to the emacs-26 branch, and thanks.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]