bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#30377: 27.0.50; Missing and misspelled SHR/CSS colors


From: Tom Tromey
Subject: bug#30377: 27.0.50; Missing and misspelled SHR/CSS colors
Date: Wed, 07 Feb 2018 08:03:47 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux)

>>>>> "Basil" == Basil L Contovounesios <address@hidden> writes:

Basil> * lisp/textmodes/css-mode.el (css--color-map): Add fuchsia-magenta
Basil> and aqua-cyan aliases.

Thanks.  According to MDN these are the only non-grey/gray aliases.
Maybe they weren't on whatever list I started with for that reason.

Basil> In that bug report, which introduced css--color-map, Eli was referring
Basil> to the list of colours in lisp/term/tty-colors.el.  I would instead like
Basil> to draw attention to the overlap between css--color-map and
Basil> shr-color-html-colors-alist.

Yes, I wasn't aware of this list from shr.  It seems to me that shr
ought to use exactly the CSS colors, so the lists can be shared.
Though, I recommend contacting Lars before doing anything.

Basil> A (very) cursory glance through bug#25525 and lisp/net/shr-color.el
Basil> suggests there may be some further code duplication pertaining to colour
Basil> distances; is this so?

It seems so but I've mostly forgotten whatever I knew about this area.

What I do remember is checking my original algorithm against the one Eli
suggested, by comparing all the CSS named colors with their backgrounds;
and concluding that the one Eli suggested (built in to Emacs) was just
as good.  So perhaps shr is doing too much work here as well.

Tom





reply via email to

[Prev in Thread] Current Thread [Next in Thread]