bug#30455: 27.0.50; problem in diary-remind

[Stefan Monnier]

> I imagine this is lexical-binding fallout. Please could you take a look?
> Thanks.
>
> Minimal example diary-file contents:
>
> %%(diary-remind '(diary-date 3 1 2018) -20 t)

I wasn't able to reproduce the problem, but looking at the code, I think
I figured the problem and installed the patch below which might fix it.

Could you or John confirm that it fixes the original problem?


        Stefan


diff --git a/lisp/calendar/diary-lib.el b/lisp/calendar/diary-lib.el
index 181b1172fa..acf4b20d77 100644
--- a/lisp/calendar/diary-lib.el
+++ b/lisp/calendar/diary-lib.el
@@ -2049,7 +2049,8 @@ diary-remind
         (when (setq diary-entry (eval sexp))
           ;; Discard any mark portion from diary-anniversary, etc.
           (if (consp diary-entry) (setq diary-entry (cdr diary-entry)))
-          (mapconcat #'eval diary-remind-message ""))))
+          (calendar-dlet* ((days days))
+            (mapconcat #'eval diary-remind-message "")))))
      ;; Diary entry may apply to one of a list of days before date.
      ((and (listp days) days)
       (or (diary-remind sexp (car days) marking)