bug#31794: 26.1; dired-do-shell-command broken

[Mark Oteiza]

On Tue, Jun 12, 2018 at 12:24 AM, Leo Liu <sdl.web@gmail.com> wrote:
>
> 1. emacs -q
> 2. in dired mode press !
> 3. C-h v
>
> Step 3 should give you no completion. Another issue is when
> icomplete-mode is on one constantly gets "No matches" for every input.
>
> This is due to the following change.
>
> commit c2a8cffe8044cc38c4cf1b5c3d1c9571ddeec623
> Date:   Sun Aug 6 10:15:17 2017 -0400
>
>     ; Fix previous commit
>
>     The mailcap minibuffer completion used dynamic binding.  Locally set
>     a dynamic variable.
>     * lisp/dired-aux.el: Store list of files in
>     `minibuffer-completion-table'.
>
> I intend to fix the issue on emacs-26 with the following patch. Comments?

Nope, looks fine to me.