bug#32319: 27.0.50; flyspell-mode error on start

[Eric Abrahamsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Eric Abrahamsen <eric@ericabrahamsen.net>
>> Cc: 32319@debbugs.gnu.org
>> Date: Wed, 01 Aug 2018 12:51:54 -0700
>> 
>> If the symlink is not present, the "hunspell -D" output looks like:
>> 
>> SEARCH PATH:.:: <elided>
>> AVAILABLE DICTIONARIES
>> /usr/share/hunspell/en_TT
>> <more>
>> Can't open affix or dictionary files for dictionary named "en_US".
>> 
>> IOW, there's no line that matches "\\.aff$", and
>> `hunspell-default-dictionary' is never set, and the error is raised in
>> line 1177, where it's assumed that that variable has a value.
>> 
>> So things go wrong pretty early on, as soon as Hunspell fails to load a
>> dictionary.
>
> Does the patch below produce a useful diagnostic?

This patch is just fine, and would certainly be a lot better than the
current situation. I only note that, if we allow this function to fail
silently, the error you get *later on*, when you try to use flyspell to
do something, comes directly from hunspell and says exactly what the
problem is (ie, which dictionary it tried and failed to load). That's
even more helpful. If we did that, this function could just call
`ispell-print-if-debug' and log the failure quietly.

But raising an error directly is also fine, and might be preferable in
order to avoid creating weird problems further down the line.

Eric