[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#33870: 27.0.50; xref-goto-xref not configurable
From: |
João Távora |
Subject: |
bug#33870: 27.0.50; xref-goto-xref not configurable |
Date: |
Thu, 27 Dec 2018 18:08:15 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 27.12.2018 2:05, João Távora wrote:
>> You can read up the whole bug here:
>>
>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28814
>>
>> I quote from that thread:
>>
>> Here are two very simple Emacs -Q recipes that demonstrate [the bug]
>
> Does this work well for everybody?
>
> diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
> index c71802c918..85d4325d9e 100644
> --- a/lisp/progmodes/xref.el
> +++ b/lisp/progmodes/xref.el
> @@ -494,7 +494,8 @@ xref--show-pos-in-buf
> (or (and (window-live-p xref--original-window)
> xref--original-window)
> (selected-window))
> - (display-buffer buf action))
> + (pop-to-buffer buf action)
> + (selected-window))
> (xref--goto-char pos)
> (run-hooks 'xref-after-jump-hook)
> (let ((buf (current-buffer)))
It works for those two recipes, because `action' is passed directly to
display-buffer. Don't know:
* if it might be introducing a new untested corner case because of the
"recording" of select-window inside. Perhaps this corner case is
unwanted, but it might also be wanted (and we didn't know).
* if it will bring Yuri what he wants. Doesn't seem like it will, since
display buffer is given an explicit ACTION.
João
- bug#33870: 27.0.50; xref-goto-xref not configurable, Juri Linkov, 2018/12/25
- bug#33870: 27.0.50; xref-goto-xref not configurable, Dmitry Gutov, 2018/12/25
- bug#33870: 27.0.50; xref-goto-xref not configurable, João Távora, 2018/12/26
- bug#33870: 27.0.50; xref-goto-xref not configurable, Juri Linkov, 2018/12/26
- bug#33870: 27.0.50; xref-goto-xref not configurable, João Távora, 2018/12/26
- bug#33870: 27.0.50; xref-goto-xref not configurable, Dmitry Gutov, 2018/12/27
- bug#33870: 27.0.50; xref-goto-xref not configurable,
João Távora <=
- bug#33870: 27.0.50; xref-goto-xref not configurable, Juri Linkov, 2018/12/27
- bug#33870: 27.0.50; xref-goto-xref not configurable, Dmitry Gutov, 2018/12/27
- bug#33870: 27.0.50; xref-goto-xref not configurable, Juri Linkov, 2018/12/27
- bug#33870: 27.0.50; xref-goto-xref not configurable, Dmitry Gutov, 2018/12/27
- bug#33870: 27.0.50; xref-goto-xref not configurable, João Távora, 2018/12/28
- bug#33870: 27.0.50; xref-goto-xref not configurable, Juri Linkov, 2018/12/27
- bug#33870: 27.0.50; xref-goto-xref not configurable, João Távora, 2018/12/27
bug#33870: 27.0.50; xref-goto-xref not configurable, Eli Zaretskii, 2018/12/26