[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34763: 27.0.50; url-retrieve-synchronously misbehaves inside eldoc-d
From: |
Eli Zaretskii |
Subject: |
bug#34763: 27.0.50; url-retrieve-synchronously misbehaves inside eldoc-documentation-function |
Date: |
Thu, 04 Apr 2019 16:04:35 +0300 |
> Cc: 34763@debbugs.gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Thu, 4 Apr 2019 02:37:49 +0300
>
> On 15.03.2019 17:49, Eli Zaretskii wrote:
>
> > The code in the functions that react to quit-flag being non-nil should
> > be audited. They don't look clean to me, FWIW, and we don't generally
> > do such things from Lisp, we normally quit on the C level. Maybe this
> > whole sub-feature, whereby we show a message for interrupted
> > transfers, should be rethought.
>
> Apparently the idea is to handle quits, including contexts where
> inhibit-quit is t (947612be2c71d2478179694e8dfa538b9e8e07c1).
>
> So url-retrieve-synchronously uses with-local-quit around
> accept-process-output, and I guess the idea was to handle quits inside
> debugging output calls.
If that's the intent, why does it need to explicitly quit in Lisp?
Just letting the code leave the form where inhibit-quit is non-nil
will let Emacs quit at the first opportunity, with no need for any
Lisp code for that.
- bug#34763: 27.0.50; url-retrieve-synchronously misbehaves inside eldoc-documentation-function, Dmitry Gutov, 2019/04/03
- bug#34763: 27.0.50; url-retrieve-synchronously misbehaves inside eldoc-documentation-function,
Eli Zaretskii <=
- bug#34763: 27.0.50; url-retrieve-synchronously misbehaves inside eldoc-documentation-function, Dmitry Gutov, 2019/04/04
- bug#34763: 27.0.50; url-retrieve-synchronously misbehaves inside eldoc-documentation-function, Eli Zaretskii, 2019/04/04
- bug#34763: 27.0.50; url-retrieve-synchronously misbehaves inside eldoc-documentation-function, Dmitry Gutov, 2019/04/04
- bug#34763: 27.0.50; url-retrieve-synchronously misbehaves inside eldoc-documentation-function, Eli Zaretskii, 2019/04/05
- bug#34763: 27.0.50; url-retrieve-synchronously misbehaves inside eldoc-documentation-function, Dmitry Gutov, 2019/04/08
- bug#34763: 27.0.50; url-retrieve-synchronously misbehaves inside eldoc-documentation-function, Eli Zaretskii, 2019/04/08
- bug#34763: 27.0.50; url-retrieve-synchronously misbehaves inside eldoc-documentation-function, Dmitry Gutov, 2019/04/08
- bug#34763: 27.0.50; url-retrieve-synchronously misbehaves inside eldoc-documentation-function, Eli Zaretskii, 2019/04/08
- bug#34763: 27.0.50; url-retrieve-synchronously misbehaves inside eldoc-documentation-function, Dmitry Gutov, 2019/04/08
- bug#34763: 27.0.50; url-retrieve-synchronously misbehaves inside eldoc-documentation-function, Eli Zaretskii, 2019/04/09