[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#33016: 26.1; (make-process ...) doesn't signal an error, when execut
From: |
Noam Postavsky |
Subject: |
bug#33016: 26.1; (make-process ...) doesn't signal an error, when executable given as absolute Windows path does not exist |
Date: |
Tue, 9 Apr 2019 10:13:58 -0400 |
On Mon, 8 Apr 2019 at 14:59, Eli Zaretskii <eliz@gnu.org> wrote:
> > The confusing thing here is that the error is signaled between
> > block_input()...unblock_input(), which prevents the debugger from
> > triggering.
> > The attached patch fixes this by moving the signal to after the
> > unblock_input().
>
> Thanks, but could we have a test for this, please?
Yes (I had initially thought it wouldn't work because of the way ert
uses the debugger internally, but it actually turns out fine).
By the way, I modified the error message in call_process in addition
to create_process for completeness, but I can't see a way to trigger
this for call_process: it searches for PROGRAM and signals an error
early, regardless of whether the filename is absolute or not.
v2-0001-Let-debugger-handle-process-spawn-errors-on-w32-B.patch
Description: Binary data
- bug#33016: 26.1; (make-process ...) doesn't signal an error, when executable given as absolute Windows path does not exist, Noam Postavsky, 2019/04/08
- bug#33016: 26.1; (make-process ...) doesn't signal an error, when executable given as absolute Windows path does not exist, Eli Zaretskii, 2019/04/08
- bug#33016: 26.1; (make-process ...) doesn't signal an error, when executable given as absolute Windows path does not exist,
Noam Postavsky <=
- bug#33016: 26.1; (make-process ...) doesn't signal an error, when executable given as absolute Windows path does not exist, Eli Zaretskii, 2019/04/09
- bug#33016: 26.1; (make-process ...) doesn't signal an error, when executable given as absolute Windows path does not exist, Noam Postavsky, 2019/04/10
- bug#33016: 26.1; (make-process ...) doesn't signal an error, when executable given as absolute Windows path does not exist, Eli Zaretskii, 2019/04/11
- bug#33016: 26.1; (make-process ...) doesn't signal an error, when executable given as absolute Windows path does not exist, Noam Postavsky, 2019/04/11
- bug#33016: 26.1; (make-process ...) doesn't signal an error, when executable given as absolute Windows path does not exist, Eli Zaretskii, 2019/04/11
- bug#33016: 26.1; (make-process ...) doesn't signal an error, when executable given as absolute Windows path does not exist, Noam Postavsky, 2019/04/11
- bug#33016: 26.1; (make-process ...) doesn't signal an error, when executable given as absolute Windows path does not exist, Eli Zaretskii, 2019/04/12
- bug#33016: 26.1; (make-process ...) doesn't signal an error, when executable given as absolute Windows path does not exist, Noam Postavsky, 2019/04/12
- bug#33016: 26.1; (make-process ...) doesn't signal an error, when executable given as absolute Windows path does not exist, Eli Zaretskii, 2019/04/12
- bug#33016: 26.1; (make-process ...) doesn't signal an error, when executable given as absolute Windows path does not exist, Noam Postavsky, 2019/04/15