[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS
From: |
Alan Third |
Subject: |
bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS |
Date: |
Tue, 18 Aug 2020 10:43:10 +0200 (CEST) |
On Tue, Aug 18, 2020 at 10:07:27AM +0200, Mattias Engdegård wrote:
> 17 aug. 2020 kl. 21.56 skrev Alan Third <alan@idiocy.org>:
>
> > + encoded_name = code_convert_string_norecord (name, Qutf_16le, 1);
>
> Presumably this should be utf_16be on big-endian platforms. We still support
> PowerPC macOS, don't we?
No, however I imagine we support GNUstep on big endian systems.
> > + str = [NSString stringWithCharacters: (const unichar *) SDATA
> > (encoded_name)
>
> Is SDATA guaranteed to be 16-bit aligned? Doesn't matter on x86 or
> PowerPC, but strictly speaking...
I've no idea, I adapted the code from make_multibyte_string in
alloc.c, and one of it's callers (although I can't remember which
right now). I'm expecting Eli to appear and tell me this is the
entirely wrong way of doing this. ;)
Anyway, as I understand it the internal representation of NS strings
are UTF-16, so the conversion through UTF-8 seems a bit of a waste if
we can go direct.
--
Alan Third
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Mattias Engdegård, 2020/08/17
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Andrii Kolomoiets, 2020/08/17
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Eli Zaretskii, 2020/08/17
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Mattias Engdegård, 2020/08/17
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Eli Zaretskii, 2020/08/17
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Mattias Engdegård, 2020/08/17
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Alan Third, 2020/08/17
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Mattias Engdegård, 2020/08/18
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS,
Alan Third <=
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Mattias Engdegård, 2020/08/18
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Eli Zaretskii, 2020/08/18
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Alan Third, 2020/08/18
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Mattias Engdegård, 2020/08/20
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Eli Zaretskii, 2020/08/20
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Mattias Engdegård, 2020/08/20
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Eli Zaretskii, 2020/08/20
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Mattias Engdegård, 2020/08/21
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Eli Zaretskii, 2020/08/21
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Mattias Engdegård, 2020/08/21