Re: Patch for 1.3.151

[Mats Bengtsson]

> Hi Mats,
> 
> Late reaction from my side, hope you can help.
> 
> > Here's a patch that hopefully should solve some of Rune's problems.
> > In ly2dvi, I added the lilypond default paths at the end instead of 
> > the front of the TeX related environment variables.
> 
> Here at work, I have lilypond1.3-1.3.150-1 installed, which has MF
> fonts in /usr/share/lilypond/mf.  In $HOME/usr/src/lilypond/mf are my
> 1.4.0 fonts.
> 
> My MFINPUTS are set to $HOME/usr/src/lilypond/mf.
> 
> Now, when I run ly2dvi foo.ly, the old mf sources in
> /usr/share/lilypond/mf will be used, although MFINPUTS and datadir
> both point to the correct directory, all gets messed up by this:

That's weird, since I explicitly changed the settings so 
the additional paths were appended instead of prepended
so the paths specified explicitly by the user should be 
searched first:

@@ -146,7 +146,7 @@
        for key in environment.keys ():
                val = environment[key]
                if os.environ.has_key (key):
-                       val = val + os.pathsep + os.environ[key]
+                       val = os.environ[key] + os.pathsep + val 
                os.environ[key] = val

I did the above change to avoid exactly the problems you 
describe.

The exchange of default search path (:) and datadir/ paths
shouldn't really matter and was done more for esthetical 
reasons. 

> Why did you do this, or why/when is this necessary?  LilyPond, or in
> this case `datadir' should be the best choice, always?
> 
> What to do?  I'd like to revert this patch, but you're the
> tex-installation guru...

The main reason for the patch was that Rune (who has a rather 
non-standard tex-setup) had problems when using ly2dvi 
even though the font lookup worked fine when using plain
Lilypond+TeX. I draw the conclusion that the settings 
in ly2dvi were overriding the settings that worked for him
and apparently the patch solved Rune's problems.

Basically, the settings in ly2dvi are primarily for people 
who have not done any Lilypond specific setup of environment
variables. For the users who have setup the environment
variables such that Lilypond+TeX works correctly, ly2dvi
shouldn't be expected to know better and override their
settings, right?

   /Mats