Re: PSPP-BUG: moments_calculate error

[John Darrington]

I had a look at this one.

The pertinent assertion is:

     /* After the second pass we can calculate any stat.  We
         don't support "online" computation during the second
         pass, so As a simple self-check, the total weight for
         the passes must agree. */
      assert (m->w1 == m->w2);

and when I ran it through gdb, I see:

Breakpoint 1, moments_calculate (m=0x81430c0, weight=0xbffff1c0, 
mean=0xbffff1b8, variance=0xbffff1b0, skewness=0xbffff1a8, 
    kurtosis=0xbffff1a0) at /home/john/pspp-master/src/math/moments.c:233
233           assert (m->w1 == m->w2);
(gdb) print m
$2 = {max_moment = MOMENT_KURTOSIS, pass = 2, w1 = 2257.1583655975705, sum = 
970999467.71251988, mean = 430186.6818527166, 
  w2 = 2257.1583655975778, d1 = 6.8955123424530029e-06, d2 = 1504554313897766, 
d3 = 2.7440683550398496e+21, 
  d4 = 9.0176522508330139e+27}

So it would appear that this is simply a floating point precision problem 
(which inevitably arises when doing
equality comparisons with floating points).  So I suggest that this assertion 
be deleted.

J'


On Sat, Dec 15, 2012 at 01:39:27PM +0100, Zolt?n F?bi?n wrote:
     Dear PSPP developers,
     
     I have got the following error message when I run the attached
     syntax on my pspp sav (attached in the zip file too).
     
     address@hidden:~/pspp_report$ pspp jov2012_report.sps -o output_report.html
     Sat Dec 15 13:26:14 CET 2012
     pspp: src/math/moments.c:233: moments_calculate: Assertion `m->w1
     == m->w2' failed.
     ******************************************************
     You have discovered a bug in PSPP.  Please report this
     to address@hidden  Please include this entire
     message, *plus* several lines of output just above it.
     For the best chance at having the bug fixed, also
     include the syntax file that triggered it and a sample
     of any data file used for input.
     proximate cause:     Assertion Failure/Abort
     version:             GNU pspp 0.7.9 (Tue Mar 27 21:08:23 UTC 2012).
     host_system:         x86_64-pc-linux-gnu
     build_system:        x86_64-pc-linux-gnu
     locale_dir:          /usr/share/locale
     compiler version:    4.6.3
     ******************************************************
     Aborted (core dumped)
     
     Obviously, the error related to sample weight (htesuly). When
     weight is OFF, than no error occurs. Should there be need for
     more info, please let me know.
     
     Best regards,
     
     Zoltan Fabian


     _______________________________________________
     Bug-gnu-pspp mailing list
     address@hidden
     https://lists.gnu.org/mailman/listinfo/bug-gnu-pspp


-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://keys.gnupg.net or any PGP keyserver for public key.

signature.asc
Description: Digital signature