Re: temp file creation bug in diffutils 2.7

[Solar Designer]

> > This new patch is almost correct, except that I believe the temporary
> > file wouldn't be unlinked (the global tmpname is never set).
> 
> IMHO, there's one other problem with this patch: it doesn't honor 
> $TMPDIR.

Yes, this is just not as important when the accesses are now safe.  I
find it unfortunate that there's no libc interface that would provide
the features of tmpnam(3) and mkstemp(3) combined.  glibc has better
interfaces internally, but these are just not standardized anywhere.
(tmpfile(3) is almost what is needed, except that it doesn't return
the filename.)

Anyway, I've fixed this in the patch, -- plus, there turned out to be
one more case where not all temporary files would be unlinked.

This is very non-portable, but I don't think this patch was ever
meant to be used anywhere other than in GNU/*/Linux distributions.

-- 
/sd

diffutils-2.7-immunix-owl-tmp.diff
Description: Text document