Re: gettext: double slash po/Makefile.in.in

[Niels Möller]

Werner Koch <address@hidden> writes:

> Niels figured out a problem with gettext when used with a VPATH build:
> 
> $ cd some-build-dir
> $ /usr/local/src/gnupg-1.0.4/configure
> ....
> 
> At some point later it tries to run mkinstalldirs but uses an
> invalid path (well under GNU/Linux it is no problem but it IIRC, he
> uses Solaris)
> 
> /usr/local/src/gnupg-1.0.4//usr/local/src/gnupg-1.0.4/scripts/mkinstalldirs
>                          ^^^
> The double slahs should be removed.  AFAIK this does only make
> with the po/Makefile. 
> 
> gettext is version 0.10.35.

The problem is not the double slash, but the duplication of the
absolute path to the srcdir. The path should be

  /usr/local/src/gnupg-1.0.4/scripts/mkinstalldirs

not

  /usr/local/src/gnupg-1.0.4//usr/local/src/gnupg-1.0.4/scripts/mkinstalldirs

po/Makefile.in.in defines MKINSTALLDIRS as

  top_srcdir = @top_srcdir@
  ...
  MKINSTALLDIRS = $(top_srcdir)/@MKINSTALLDIRS@

and configure substitutes absolute paths for both @top_srcdir@ and
@address@hidden

Next, typical use of MKINSTALLDIRS further down in Makefile.in.in is

        if test -r "$(MKINSTALLDIRS)"; then \
          $(MKINSTALLDIRS) $(datadir); \
        else \
          $(SHELL) $(top_srcdir)/mkinstalldirs $(datadir); \
        fi

$(MKINSTALLDIR) is the bogus path above, and
$(top_srcdir)/mkinstalldirs doesn't work either.
$(top_srcdir)/scripts/mkinstalldirs would work, I think.

/Niels