[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
intl/Makefile po/Makefile bug
From: |
Andrew Clausen |
Subject: |
intl/Makefile po/Makefile bug |
Date: |
Sat, 16 Nov 2002 07:40:03 +1100 |
User-agent: |
Mutt/1.4i |
Hi all,
This Makefile code is problematic:
for file in $$dists; do \
if test -f $$file; then dir=.; else dir=$(srcdir); fi; \
$(INSTALL_DATA) $$dir/$$file \
$(DESTDIR)$(gettextsrcdir)/$$file; \
done; \
It appears many times in po/Makefile and intl/Makefile.
Anyway, it breaks if $$file contains an absolute path. You get:
".//the/path" which doesn't resolve properly.
$$file may be an absolute path if you use gettext in another program,
and have your build and source directories separate.
I suggest, the following replacement code:
for file in $$dists; do \
if test -f $$file; then dir=; else dir=$(srcdir)/; fi; \
$(INSTALL_DATA) $$dir$$file \
$(DESTDIR)$(gettextsrcdir)/$$file; \
done; \
This code seems to be the same in 0.10.40 and 0.11.5.
BTW: which version is recommended for stable branches of free softare
projects?
Cheers,
Andrew
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- intl/Makefile po/Makefile bug,
Andrew Clausen <=