Re: [Mingw-users] Re: More patch 2.5.9 hacking

[Paul Eggert]

"Manu" <address@hidden> writes:

> > If it's some other patch then I must have missed it; sorry.
> 
> Here it is:
> http://mail.gnu.org/archive/html/bug-gnu-utils/2003-10/msg00168.html

Thanks, but we need to know why those changes were needed.

In common.h, the proposed change moves the mkdir macro definition to
the end of the file.  Presumably this is because some of the
intervening include files declares mkdir.  Which include file is it?

In mkdir.m4, the proposed change avoids including <sys/types.h>
and <sys/stat.h>.  This will break 'configure' on non-mingw platforms,
so I'd rather leave those include directives in.  Is it really necessary
to remove these include directives on mingw?  Why?

Also, in mkdir.m4, the proposed change includes <dir.h>
unconditionally.  Presumably this is an include file that is available
on mingw.  It is not available on other platforms, so we can't include
it unconditionally.  Also, nowhere else does the mainline code include
<dir.h>, and this doesn't sound correct: if the configure test
includes <dir.h>, then the actual code should include <dir.h>.
Conversely, since you had to make the above-described change to
<common.h>, this suggests that mkdir is declared by one of the
standard include files.  If so, I'd rather test with that file (which
the mainline code is already using) than with <dir.h>.