Re: major gawk bug

[Stanislav Ievlev]

Hello,

On Tue, Jun 08, 2004 at 06:59:48PM +0300, Aharon Robbins wrote:
> > I beleive the right fix for regexes is to use RE_ICASE flag instead
> > of the translate table.
> > The hard-coded table is also used in gawk for various case-insensitive
> > comparisons; these should be replaced by a call to tolower().
> > The hard-coded table should be then removed.
> 
> I have some tentative changes in place that work this way.  It passes
> `make check'.  I am still concerned about performance, especially
> the use of tolower().
> 
> If you or Mr. Ievlev can test them and give me some feedback, let
> me know and I'll send them to you.
Arnold, your patch works well.
(little improvement:
-       if (strcmp(cp, "C") == 0 || strcmp(cp, "POSIX") == 0)
+       if (!cp || strcmp(cp, "C") == 0 || strcmp(cp, "POSIX") == 0)
)

As I understand, we also have a solution with toupper()/tolower() functions.

I agree with Stepan that these functions already have good optimization in
glibc. Solution with toupper()/tolower() is better, because currently we
have two translation tables (first in  glibc and second in gawk) and copy one 
to other
during initialization (load_ignorecase ), it looks strange.

If interpretation of contents of these two tables is identical in gawk
algorithms, it's eazy to replace one another.

--
With best regards
Stanislav Ievlev

ALT Linux Team.