[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: libexecdir/datadir used incorrectly
From: |
Aharon Robbins |
Subject: |
Re: libexecdir/datadir used incorrectly |
Date: |
Sun, 6 Feb 2005 16:01:02 +0200 |
Mr. Szmidt,
Thank you for your patch.
I don't really see that gawk as currently using things is not GCS
conforming.
I also don't see that practically speaking your changes make a difference
in what directories get used/removed, except for the rename from `awk'
to `gawk'. As gawk is `awk' on a GNU system, I think the rename is
incorrect.
So, I don't see that I really need to apply this patch. Is there some
real-world situation where the current code doesn't work and the version
as you've patched it does? If so, I'd like to hear the details.
Thanks,
Arnold
> Date: Sat, 05 Feb 2005 19:43:01 +0100
> From: "Alfred M. Szmidt" <address@hidden>
> Subject: libexecdir/datadir used incorrectly
> To: address@hidden
>
> [I'm not subscribed to bug-gawk, so please CC]
>
> libexecdir/datadir are used incorrectly. I haven't check for any
> other references to datadir/libexecdir in gawk. Anyway, here is a
> patch to make gawk GCS conforming.
>
> `datadir'
> ...
> The default definition of `datadir' should be `$(datarootdir)'.
> (If you are using Autoconf, write it as address@hidden@'.)
>
> (the same applies for libexecdir)
>
>
> A nice thing might be to install libexec programs into
> $(libexecdir)/gawk/MACHINE-TRIPPLE/VERSION/
> (e.g. /libexec/gawk/i686-pc-gnu0.3/3.1.3/), like many other GNU
> programs do (gcc and emacs come from the top of my head).
>
> Happy hacking.
>
> 2005-02-05 Alfred M. Szmidt <address@hidden>
>
> * Makefile.am (datadir, libexecdir): Conform to the GCS, all
> references updated accordingly.
>
> diff -up /home/ams/gsc/text/gawk/gawk-3.1.3/awklib/Makefile.am
> /tmp/buffer-content-4797R5Q
> --- /home/ams/gsc/text/gawk/gawk-3.1.3/awklib/Makefile.am 2003-02-04
> 13:08:16.000000000 +0100
> +++ /tmp/buffer-content-4797R5Q 2005-02-05 19:20:01.000000000 +0100
> @@ -29,8 +29,8 @@ EXTRA_DIST = ChangeLog extract.awk eg st
> # not the source directory.
> INCLUDES = -I..
>
> -datadir = @datadir@/awk
> -libexecdir = @libexecdir@/awk
> +datadir = @datadir@
> +libexecdir = @libexecdir@
>
> bin_SCRIPTS = igawk
> libexec_PROGRAMS = pwcat grcat
> @@ -41,15 +41,15 @@ nodist_pwcat_SOURCES = pwcat.c
> all: stamp-eg $(AUXPROGS) igawk $(AUXAWK)
>
> install-exec-hook: $(AUXAWK)
> - $(mkinstalldirs) $(DESTDIR)$(datadir)
> + $(mkinstalldirs) $(DESTDIR)$(datadir)/gawk
> for i in $(AUXAWK) $(srcdir)/eg/lib/*.awk ; do \
> progname=`echo $$i | sed 's;.*/;;'` ; \
> - $(INSTALL_DATA) $$i $(DESTDIR)$(datadir)/$$progname ; \
> + $(INSTALL_DATA) $$i $(DESTDIR)$(datadir)/gawk/$$progname ; \
> done
>
> # libexecdir and datadir are removed in the top level Makefile's uninstall
> uninstall-local:
> - rm -fr $(DESTDIR)$(libexecdir)/* $(DESTDIR)$(datadir)/*
> + rm -fr $(DESTDIR)$(libexecdir)/gawk $(DESTDIR)$(datadir)/gawk
> rm -f $(DESTDIR)$(bindir)/igawk
>
> clean-local:
- Re: libexecdir/datadir used incorrectly, (continued)
- Re: libexecdir/datadir used incorrectly, Alexandre Duret-Lutz, 2005/02/08
- Re: libexecdir/datadir used incorrectly, Alfred M. Szmidt, 2005/02/08
- Message not available
- Re: libexecdir/datadir used incorrectly, Alexandre Duret-Lutz, 2005/02/08
- Re: libexecdir/datadir used incorrectly, Eli Zaretskii, 2005/02/09
- Re: libexecdir/datadir used incorrectly, Stepan Kasal, 2005/02/08
- Re: libexecdir/datadir used incorrectly, Alfred M. Szmidt, 2005/02/07
Re: libexecdir/datadir used incorrectly,
Aharon Robbins <=
Re: libexecdir/datadir used incorrectly, Aharon Robbins, 2005/02/08
Re: libexecdir/datadir used incorrectly, Aharon Robbins, 2005/02/10