[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: patch 2.5.4 ISO C90 compliance patch
From: |
Paul Eggert |
Subject: |
Re: patch 2.5.4 ISO C90 compliance patch |
Date: |
Fri, 17 Nov 2006 09:46:56 -0800 |
User-agent: |
Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux) |
Thanks for the patch. Some comments:
I don't understand the first and third hunks of the proposed change to
patch/patch.c; they seem irrelevant to the issue of porting 'patch'.
I don't understand the second hunk, either. The emulation package
has fdopen, so why can't it be used here, too?
I assume you fixed the strncasecmp-is-missing bug by using gnulib's
version; that's what I was planning to do.
>From our recent diffutils conversation it appears that changes like
this:
+ #if HAVE_SYS_TYPES_H
#include <sys/types.h>
+ #endif
won't be needed, as you can arrange for '#include <sys/types.h>' to be
a no-op on your platform by using the appropriate DD statement.