Re: Two bugs when compiling on mingw (patches included)

[Bruno Haible]

Hello,

Gert Wollny wrote:
> I've found a bug when compiling gettext 1.16.1 on mingw: 
> 
> gettext-tools/woe32dll/gettextsrc-exports.c
> If HAVE_ICONV is not defined the linker complains about a missing symbol
> 'po_lex_iconv' since the variable is only defined in 'po-charset.c' if
> HAVE_ICONV is defined.

GNU gettext works reasonably only with an iconv() implementation. Around
40 tests, part of the test suite, fail if iconv is not available. Therefore
the primary mode of building gettext is when libiconv has been built and
installed first.

In the next release, a file 'DEPENDENCIES' will make clear that GNU libiconv
is highly recommended as a prerequisite on mingw.

> Attached patch solves this accordingly. 

It has the effect of getting past the build failure without iconv. But it
will introduce a build failure when building _with_ iconv, because HAVE_ICONV
is defined by <config.h>, which is not #included in gettextsrc-exports.c.

Bruno