Re: [Bug-gnubg] Tutor mode patches for gnubg

[Jim Segrave]

On Wed 24 Jul 2002 (12:07 +0200), Øystein O Johansen wrote:
> 
> > If anyone can tell me why clicking the Tutor box in the
> > Settings/Options menu doesn't make a permanent change,
> > I'd appreciate that as well.
> 
> It's the CHECKUPDATE macro. In the OptionsOK() in gtkgame.c it should read:
> 
>   CHECKUPDATE(pow->pwTutor, fTutor, "set tutor %s")
> 
> instead of:
> 
>   CHECKUPDATE(pow->pwTutor, fTutor, "warn about errors in play %s")

Aha - I didn't pay enough attention when I copied AutoRoll, so I
didn't notice it was a comand and not a comment.
 
> For those who apply this patch:
> There is a function declaration missing in gtkgame.h, I guess.
> You should add this declaration to the file:
> 
> extern int GtkTutor ( char *sz );

Yep - oversight.

> Some small unimportant things:
> 
> In play.c, ShouldDouble(),
>   an array float aarStdDev[ 2 ][ NUM_ROLLOUT_OUTPUTS ]; is not in use I
> believe.

Yes - over-enthusiastic cut & paste

> In gtkgame.c there's a global pointer defined as pwTutorial. I don't think
> this in use. Can be removed.

Leftovers from playing with a permanent window rather than a
pop-up. It should go.

> In gtkgame.c, GtkTutor() it's possible to comment out the line #include
> "gnu.xpm"
> 
> Thanks again Jim!

It was a pleasure doing this. I hope others find it a useful learning
aid.


-- 
Jim Segrave           address@hidden