Re: [Bug-gnubg] matchid - resignation offered

[Martin Janke]

On Fri, 2003-04-04 at 22:14, Joern Thyssen wrote: 
> On Fri, Apr 04, 2003 at 09:07:57PM +0200, mjan wrote
> > Hi,
> > 
> > when setting up a matchid which includes one of the players having
> > offered to resign, gnubg changes the matchid to a value which does not
> > include the resignation:
> [snip]
> > Is this supposed to be like this, or is this a bug?
> 
> Bug :-(
> 
> I've commited a fix.

[...]

Hi,

hmm, I tried the fixed version, but the bug still exists. You get the
same when one player offers to resign and you issue a "set board"
command: the resign value of the matchid is changed back.

Joern's fix was in ShowBoard (play.c) , which calls CommandSetBoard,
which calls AddMoveRecord, which calls ApplyMoveRecord and there you
find:

pms->fResigned = pms->fResignationDeclined = 0;

With this line commented out, the problem doesn't exist. But then, if a
resignation has been offered and one starts a new match without
accepting/declining, the new match starts with "player offers to resign
...".

Shouldn't the line above be (accordingly) in ClearMatch()? Or are there
other reasons for having it in ApplyMoveRecord ?


/Martin