Re: [Bug-gnubg] weirdness when toggling MWC in hint

[Jim Segrave]

On Tue 05 Aug 2003 (09:55 +0200), Henrik Ravn wrote:
> Hi there!
> 
> match-id: MBngACAAIAAA
> pos-id:   sNfEAVBMz5QBKA
> platform: GNU BG Build 2003-07-27 on Windows XP or 030804 snapshot
> 
> To reproduce:
> 
> Enter the above match/position and get a hint (Ctrl-H). It should now display 
> a double/pass with sane equites. Now toggle the MWC button on/off and watch 
> as the equities goes straight into the twilight zone. In some cases gnubg 
> just crashes (exits silently), in others it just displays really weird values.
> 

Thanks for the report - it was a bug and your report made it trivial
to find and fix.
I've committed a fix for it.

Along with it I've put in code which should deal with locales which
label the character set as 

ISO8859-x or ISO_8859-x. In both cases, it's converted to 
ISO-8859-x internally. I also fixed things so that nl_open failing
should call perror - Joern's suggestion.

I've tried setting LANG=de_DE.ISO8859-1 and LANG=da_DK.ISO_8859-1 both
of which appear to work correctly now, whereas they caused SIGSEGV
before.

For the techies:

The HintTake (and some others) routine set up the array of
win/wing/winbg.../cubless/cubeful array as a local variable (and the
current cube settings etc), then called the routine which eventually
pops up the gtk hint window. Once the window is up, control returns to
HintTake, which exits and its locals are gone, including the chances
and equities. Redisplaying the window used whatever was on the stack
where the chances and equities once lived. Fixed by making the locals
statics within the functions.

-- 
Jim Segrave           address@hidden